Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSH keys shell script and find-extra-config-files PHP script #54

Closed
wants to merge 8 commits into from

Conversation

@sibprogrammer sibprogrammer self-requested a review February 26, 2024 12:01
Copy link
Member

@sibprogrammer sibprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split it into two separate pull requests (one for each script)

@sibprogrammer
Copy link
Member

The words in the directory name should be separated by dashes. "ssh_keys" -> "ssh-keys"

@@ -0,0 +1,37 @@
#!/bin/bash

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright notice is missed

@@ -0,0 +1,187 @@
<?php

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright notice is missed

sleep 1
echo -e "\e[1;31m Done. \e[0m"

echo -e "\e[1;42m6. The Plesk SSH Support Key has been installed under the user $(whoami). Please pass that information to the Support team. \e[0m"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File should have an empty trailing line

*
* @return \mysqli database handler
*/
function get_psa_sql_handle()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function names violate PHP code style

<?php

/**
* Connects to the psa database
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc blocks are incorrectly formatted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants