-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSH keys shell script and find-extra-config-files PHP script #54
Conversation
vincentlauton
commented
Feb 22, 2024
- Script from KB https://support.plesk.com/hc/en-us/articles/12377651541527-How-to-provide-Plesk-Support-with-server-access to install SSH key from Git
- Add script from article https://support.plesk.com/hc/en-us/articles/12377594456087-PHP-FPM-handler-failed-to-be-configured-for-domain-on-Plesk-for-Linux-server-An-another-FPM-instance-seems-to-already-listen-on
- Add corresponding KB flags
Script from KB https://support.plesk.com/hc/en-us/articles/12377651541527-How-to-provide-Plesk-Support-with-server-access to install SSH key from Git
Add script for adding SSH keys through CLI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split it into two separate pull requests (one for each script)
The words in the directory name should be separated by dashes. "ssh_keys" -> "ssh-keys" |
@@ -0,0 +1,37 @@ | |||
#!/bin/bash | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright notice is missed
@@ -0,0 +1,187 @@ | |||
<?php | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright notice is missed
sleep 1 | ||
echo -e "\e[1;31m Done. \e[0m" | ||
|
||
echo -e "\e[1;42m6. The Plesk SSH Support Key has been installed under the user $(whoami). Please pass that information to the Support team. \e[0m" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File should have an empty trailing line
* | ||
* @return \mysqli database handler | ||
*/ | ||
function get_psa_sql_handle() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function names violate PHP code style
<?php | ||
|
||
/** | ||
* Connects to the psa database |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc blocks are incorrectly formatted
Add copyright
Add empty trailing line