Enhancements to Mail Filesize/Filename Fixer Script #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in directories Fixed a bug where only colon separators where detected (:) but also comma (,) separators are possible – for accurate file identification (just checking for ,S= is sufficient here). Implemented -print0 and -z flags in find and grep commands for robust handling of directories containing spaces.
Refactored the check_filenames function to count the total number of files while checking for size mismatches. This change eliminates the need for an additional file read operation previously performed to count the total files. The script now reads the files only once, improving its efficiency.
This commit changes the README file from Markdown to AsciiDoc format. AsciiDoc is chosen over Markdown due to its richer set of features. This change will make the README more versatile and maintainable.
sibprogrammer
requested changes
Apr 10, 2024
|
@sibprogrammer done. Sorry, d62743e for some reason got |
sibprogrammer
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
These changes aim to improve the script’s performance and usability.