Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding script for removing obsolete records from PES SpamAssassin DB #66

Closed
wants to merge 1 commit into from
Closed

Adding script for removing obsolete records from PES SpamAssassin DB #66

wants to merge 1 commit into from

Conversation

lgukhman
Copy link
Contributor

No description provided.

@sibprogrammer
Copy link
Member

Adding script for removing obsolete records from PES SpamAssassin DB

Please use imperative mood: "Add script for.." instead of "Adding"
See https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project

@sibprogrammer sibprogrammer self-requested a review May 21, 2024 09:53
sibprogrammer
sibprogrammer reviewed May 21, 2024
View reviewed changes
Copy link
Member

@sibprogrammer sibprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's follow the practice we use for the rest of scripts:

  • name the main entry point as the directory (e.g., pes-sa-remove.php)
  • use one script for check and fix operations (to avoid code duplication); introduce --fix option and --help

sibprogrammer
sibprogrammer requested changes May 21, 2024
View reviewed changes
Copy link
Member

@sibprogrammer sibprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of code style violations. Please read and follow: https://www.php-fig.org/psr/psr-12/

@lgukhman lgukhman closed this by deleting the head repository Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sibprogrammer sibprogrammer sibprogrammer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgukhman @sibprogrammer