Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size update(non dynamic) #112

Closed
wants to merge 2 commits into from
Closed

Conversation

SYBIOTE
Copy link

@SYBIOTE SYBIOTE commented Oct 6, 2019

doubled the size of the board horizontally

doubled the size of the board horizontally
increased size horizontally to accommodate bigger strings
Repository owner deleted a comment Oct 6, 2019
Repository owner deleted a comment Oct 6, 2019
@tcoyvwac
Copy link
Collaborator

Hi @SYBIOTE, thanks for the PR! 🐱

It would be great if 2048.cpp changed its tile width! It would help with presenting high values which are large.

Please know that Issue #54 currently hints on this problem while PR #56 also begins to provide a solution.

The challenge is that the project is currently working towards Issue #51 (theming).
This requires that the tile width needs to be dynamic for many values it may have to present to a player.
Your PR results in a hard-coded / static change, and will not be able to scale with / is blocked by Issue #51.
Unfortunately, this means I cannot accept your PR to the codebase.

Thanks again and please contribute once more in the near future! 🐈

@tcoyvwac tcoyvwac closed this Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants