fix: Gracefully fail when getUserData fetch returns HTTP 503 #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed the same issue described in #102 where the extension is sometimes stuck in the loading wheel phase. After some playing around, it looks like the problem happens when the
getUserData
fetch returns HTTP response status code 503 which sometimes happens with HackerNews if you refresh quickly or open a lot of links at once. The fetched page looks like this:Because of the 503 page, the resulting
topBarElements
is empty andactualTopBar
is set toundefined
which leads to anUncaught (in promise) TypeError: Cannot read properties of undefined (reading 'children')
on line 90 of theutils.js
file.Steps to reproduce
actualTopBar
will becomeundefined
.