Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMS-7112: Fix for MMS API Responses #290

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/plivo/api/PlivoAPIService.java
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,9 @@ Call<ListResponse<Message>> messageList(@Path("authId") String authId,
Call<Message> messageGet(@Path("authId") String authId, @Path("id") String id);

@GET("Account/{authId}/Message/{id}/Media/")
Call<ListResponse<MmsMedia>> mmsMediaList(@Path("authId") String authId, @Path("id") String id);
Call<ListResponse<MmsMedia>> mmsMediaList(@Path("authId") String authId, @Path("id") String id, @QueryMap Map<String, Object> mediaListRequest);

@GET("Account/{authId}/Message/{id}/Media/{media_id}/")
@GET("Account/{authId}/Message/{id}/Media/{media_id}/")
Call<MmsMedia> mmsMediaGet(@Path("authId") String authId, @Path("id") String id, @Path("media_id") String media_id);

@DELETE("Account/{authId}/Message/{id}/Media/")
Expand Down
23 changes: 8 additions & 15 deletions src/main/java/com/plivo/api/models/media/Media.java
Original file line number Diff line number Diff line change
@@ -1,33 +1,34 @@
package com.plivo.api.models.media;

import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.plivo.api.exceptions.ResourceNotFoundException;
import com.plivo.api.models.base.BaseResource;

@JsonIgnoreProperties(value = {"id"})
@JsonInclude(JsonInclude.Include.NON_NULL)
public class Media extends BaseResource {

private String mediaId;
private String fileName;
private String contentType;
private int size;
private String uploadTime;
private String url;

private String status;
private int statusCode;
private String mediaUrl;

public static MediaUploader creator(
String[] fileNames) throws ResourceNotFoundException {
return new MediaUploader(fileNames);
}


public static MediaGetter getter(String id) {
return new MediaGetter(id);
}

public static MediaLister lister() {
return new MediaLister();
}


public String getMediaId() {
return mediaId;
Expand All @@ -49,16 +50,8 @@ public String getUploadTime() {
return uploadTime;
}

public String getUrl() {
return url;
}

public String getStatus() {
return status;
}

public int getStatusCode() {
return statusCode;
public String getMediaUrl() {
return mediaUrl;
}

@Override
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/com/plivo/api/models/media/MediaGetter.java
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
package com.plivo.api.models.media;

import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
import com.plivo.api.models.base.Getter;
import retrofit2.Call;
public class MediaGetter extends Getter<Media> {

@JsonIgnoreProperties(value = {"id"})
public MediaGetter(String id) {
super(id);
}
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/plivo/api/models/media/MediaLister.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import com.plivo.api.models.base.ListResponse;
import com.plivo.api.models.base.Lister;
import com.plivo.api.models.media.Media;

import retrofit2.Call;

public class MediaLister extends Lister<Media> {
Expand Down
4 changes: 3 additions & 1 deletion src/main/java/com/plivo/api/models/media/MediaResponse.java
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
package com.plivo.api.models.media;

import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
import com.plivo.api.models.base.BaseResponse;

import java.util.List;

//@JsonIgnoreProperties(value = {"status_code","status"})
public class MediaResponse extends BaseResponse {
private List<MediaUploadResponse> objects;


@JsonIgnoreProperties(value = {"status_code","status"})
public List<MediaUploadResponse> getObjects() {
return objects;
}
Expand Down
36 changes: 27 additions & 9 deletions src/main/java/com/plivo/api/models/message/MmsMedia.java
Original file line number Diff line number Diff line change
@@ -1,33 +1,51 @@
package com.plivo.api.models.message;

import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.plivo.api.models.base.BaseResource;

@JsonIgnoreProperties(value = {"id"})
@JsonInclude(JsonInclude.Include.NON_NULL)
public class MmsMedia extends BaseResource {
private String content_type;
private String media_id;
private String media_url;
private String message_uuid;
private long size;
private String mediaId;
private String fileName;
private String contentType;
private long size;
private String uploadTime;
private String mediaUrl;
private String messageUuid;

public static MmsMediaLister listMedia(String message_uuid) {
return new MmsMediaLister(message_uuid);
}

public String getContentType() {
return content_type;
return contentType;
}

public String getMediaId() {
return media_id;
return mediaId;
}

public String getMediaUrl() {
return media_url;
return mediaUrl;
}

public String getMessageUuid() {
return message_uuid;
return messageUuid;
}

public long getSize() {
return size;
}

public String getFileName() {
return fileName;
}

public String getUploadTime() {
return uploadTime;
}

@Override
public String getId() {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package com.plivo.api.models.message;

import com.plivo.api.models.base.ListResponse;

import com.plivo.api.models.base.Lister;
import retrofit2.Call;

public class MmsMediaLister extends Lister<MmsMedia> {

private String id;

public MmsMediaLister(String id) {
Expand All @@ -14,6 +14,6 @@ public MmsMediaLister(String id) {

@Override
protected Call<ListResponse<MmsMedia>> obtainCall() {
return client().getApiService().mmsMediaList(client().getAuthId(), id);
return client().getApiService().mmsMediaList(client().getAuthId(), id, toMap());
}
}
Loading