Skip to content

Commit

Permalink
Add GitHub action to test PR on coredev.
Browse files Browse the repository at this point in the history
This is a gitHub Action for testing a package PR on buildout.coredev.
For now (May 2022) it is an experiment, but I think we need it.
Reasons:

1. The robot tests on Jenkins are flaky/unstable, which most likely is due to several robot jobs running parallel on one node.
2. Python 3.10 is not working with the 'Python Shining Pandas' plugin we use on Jenkins.  We had it running with a different script for a while, but these changes got lost.  Should be restorable, but let's try GHA.

One thing to watch out for, is that robot tests are not always reported as failures.
On the one hand there is config for that on Jenkins:
plone/jenkins.plone.org#297
On the other hand I see the same problem locally:
#3537
But those two problems seem solved by now (June 2022).

We use a reusable workflow in [`plone/.github`](https://github.com/plone/.github/blob/main/reusable-workflows/coredev.yml).

Aftwerwards, we could install it in all relevant Plone repos using https://github.com/asottile/all-repos
But nothing too hasty. :-)
  • Loading branch information
mauritsvanrees authored and petschki committed Jun 9, 2022
1 parent 6225c4a commit 3084b15
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .github/workflows/coredev-60.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# This is a GitHub Action for testing a PR of the current package on buildout.coredev.
# See https://github.com/plone/.github/blob/main/.github/workflows/coredev-60.yml
name: Test PR on buildout.coredev 6.0
on: pull_request
jobs:
test-coredev:
uses: plone/.github/.github/workflows/coredev-60.yml@main
3 changes: 3 additions & 0 deletions news/3540.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Run all robot tests and all Py 3.10 tests on GitHub Actions.
Uses a new reusable workflow.
[maurits]

0 comments on commit 3084b15

Please sign in to comment.