Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtemplates are not working properly on windows #531

Closed
me-kell opened this issue Nov 24, 2022 · 0 comments · Fixed by #537
Closed

Subtemplates are not working properly on windows #531

me-kell opened this issue Nov 24, 2022 · 0 comments · Fixed by #537

Comments

@me-kell
Copy link
Contributor

me-kell commented Nov 24, 2022

Subtemplates are not working properly on windows due to a wrong path calculation.

The function bobtemplates.plone.base. base_prepare_renderer uses / to split paths. Paths on windows use \ and are not splitted. Resulting in wrong paths and failing to generate the templates.

The solution is to replace / by os.path.sep

This has already been reported on #510 (comment).

I can confirm this solves the problem in Plone-5.2.x and Plone-6.0.0rc1!

Any chance to get this fixed for Plone-6.0.0rc2?

me-kell added a commit to me-kell/bobtemplates.plone that referenced this issue Nov 24, 2022
me-kell added a commit to me-kell/bobtemplates.plone that referenced this issue Nov 25, 2022
me-kell added a commit to me-kell/bobtemplates.plone that referenced this issue Nov 25, 2022
me-kell added a commit to me-kell/bobtemplates.plone that referenced this issue Nov 25, 2022
me-kell added a commit that referenced this issue Dec 5, 2022
me-kell added a commit that referenced this issue Dec 5, 2022
- replace backslash with os.path.sep #531 [me-kell]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant