Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace / with os.path.sep #532

Closed
wants to merge 15 commits into from
Closed

replace / with os.path.sep #532

wants to merge 15 commits into from

Conversation

me-kell
Copy link
Contributor

@me-kell me-kell commented Nov 24, 2022

Solves #531 and #510

@mister-roboto
Copy link

@me-kell you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

@me-kell me-kell closed this Nov 24, 2022
@me-kell me-kell reopened this Nov 24, 2022
@me-kell
Copy link
Contributor Author

me-kell commented Nov 24, 2022

I'm afraid, I did something wrong. But I don't understand what.
I could use some help.

There is a message "Pyhon package / build (3.8) (pull request)" failing.
Which reads Imports are incorrectly sorted and/or formatted.
In my commit I just replaced / with os.path.sep. See https://github.com/plone/bobtemplates.plone/pull/532/files.
I did not change any imports.

@jensens
Copy link
Member

jensens commented Nov 25, 2022

In Plone we use isort with a rule in setup.cfg. So running isort should fix it.

@mister-roboto
Copy link

me-kell your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@mister-roboto
Copy link

me-kell your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@mister-roboto
Copy link

me-kell your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@mister-roboto
Copy link

me-kell your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@mister-roboto
Copy link

me-kell your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@mister-roboto
Copy link

me-kell your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@mister-roboto
Copy link

me-kell your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@me-kell me-kell closed this Nov 25, 2022
@me-kell me-kell deleted the os_path_sep branch November 25, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants