Controlpanel fixes

[1letter]

• fix The workflow action edit view uses WorkflowAddForm instead of WorkflowEditForm #75
• fix dont show the card element in conrolpanel if no rules defined #102
• fix dont show tabs in modals #103
• fix Notify content rules can not be edited Products.CMFPlone#4046

[mister-roboto]

@1letter thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

[1letter]

@jenkins-plone-org please run jobs

[1letter]

@jenkins-plone-org please run jobs

[1letter]

@petschki i would add the robot tests in Products.CMFPlone

[petschki]

@petschki i would add the robot tests in Products.CMFPlone

I'd update the doctests here https://github.com/plone/plone.app.contentrules/blob/master/plone/app/contentrules/tests/assignment.txt#L63 ... so we do not depend on another package here.

In general we have to think about the robottests in CMFPlone for version 7.0 ... they should live somewhere in a Classic-UI package (not the distribution plone.classicui) ... I could image to move them to plone.app.layout as its the designated package for Classic-UI layout/template package (see plone/Products.CMFPlone#3953 (comment))

[1letter]

I'd update the doctests

you mean "remove the test" and "convert it to robot tests"?

[1letter]

@jenkins-plone-org please run jobs