Require setuptools 68.2 or higher for building the package. #385
Conversation
When built with setuptools 68.1, you could not import the package, at least not an editable package. Note that you can still *install* this package with older setuptools versions. See [Plone meta issue 172](plone/meta#172) for details. New problem though. `tox -e dependencies` says: ``` ERROR Missing dependencies: setuptools>=68.2 ``` I tried with `setuptools<68.1', which would also work, but that only changes the message: ``` ERROR Missing dependencies: setuptools<68.1 ``` I think this is a shortcoming in `z3c.dependencychecker`. It should not report this as a missing dependency. It should see that `pyproject.toml` has this dependency covered. We definitely should *not* require `setuptools>=68.2` in `install_requires`.
|
@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@gforcada Do you remember the reason for adding |
|
Let's check on Jenkins for good measure. |
|
Sorry for the lateness, indeed the |
mauritsvanrees
deleted the
maurits-minimum-setuptools-version-for-build
branch
When built with setuptools 68.1, you could not import the package, at least not an editable package. Note that you can still install this package with older setuptools versions. See Plone meta issue 172 for details.
New problem though.
tox -e dependenciessays:I tried with `setuptools<68.1', which would also work, but that only changes the message:
I think this is a shortcoming in
z3c.dependencychecker. It should not report this as a missing dependency. It should see thatpyproject.tomlhas this dependency covered.We definitely should not require
setuptools>=68.2ininstall_requires.