Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused and broken member-registration control panel #128

Merged
merged 2 commits into from
Jun 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/meta.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,13 @@ jobs:
# os_dependencies = "git libxml2 libxslt"
##

##
# To test against a specific matrix of python versions
# when running tests jobs, add in .meta.toml:
# [github]
# py_versions = "['3.12', '3.11']"
##


##
# Specify additional jobs in .meta.toml:
Expand Down
5 changes: 4 additions & 1 deletion .meta.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,11 @@
# See the inline comments on how to expand/tweak this configuration file
[meta]
template = "default"
commit-id = "123ebc0a"
commit-id = "a89af8f2"

[pyproject]
codespell_ignores = "complet,exemple"
dependencies_ignores = "['Products.CMFPlone']"
dependencies_mappings = [
"Pillow = ['PIL']",
]
8 changes: 4 additions & 4 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ ci:

repos:
- repo: https://github.com/asottile/pyupgrade
rev: v3.15.0
rev: v3.15.2
hooks:
- id: pyupgrade
args: [--py38-plus]
Expand All @@ -16,7 +16,7 @@ repos:
hooks:
- id: isort
- repo: https://github.com/psf/black
rev: 24.1.1
rev: 24.4.2
hooks:
- id: black
- repo: https://github.com/collective/zpretty
Expand Down Expand Up @@ -44,7 +44,7 @@ repos:
# """
##
- repo: https://github.com/codespell-project/codespell
rev: v2.2.6
rev: v2.3.0
hooks:
- id: codespell
additional_dependencies:
Expand All @@ -71,7 +71,7 @@ repos:
- id: check-python-versions
args: ['--only', 'setup.py,pyproject.toml']
- repo: https://github.com/collective/i18ndude
rev: "6.1.0"
rev: "6.2.0"
hooks:
- id: i18ndude

Expand Down
4 changes: 4 additions & 0 deletions news/127.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Remove unused and broken member-registration control panel.
This still tried to use the ``portal_properties`` tool.
Since Plone 5.0 the ``member-fields`` control panel is used instead.
[maurits]
7 changes: 0 additions & 7 deletions plone/app/users/browser/configure.zcml
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,6 @@
file="permissions.zcml"
/>

<browser:page
name="member-registration"
for="plone.base.interfaces.IPloneSiteRoot"
class=".registersettingspanel.RegistrationControlPanel"
permission="plone.app.controlpanel.UsersAndGroups"
/>

<browser:page
name="register"
for="plone.app.layout.navigation.interfaces.INavigationRoot"
Expand Down
81 changes: 0 additions & 81 deletions plone/app/users/browser/registersettingspanel.py

This file was deleted.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ target-version = ["py38"]
##

[tool.codespell]
ignore-words-list = "discreet,complet,exemple"
ignore-words-list = "discreet,assertin,complet,exemple"
skip = "*.po,"
##
# Add extra configuration options in .meta.toml:
Expand Down