Skip to content

Commit

Permalink
deletes outdated note
Browse files Browse the repository at this point in the history
  • Loading branch information
edublancas committed Jul 13, 2023
1 parent 03247ed commit ec6e9db
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions src/sql/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ class ResultSet(ColumnGuesserMixin):
preview based on the current configuration)
"""

# user to overcome a duckdb-engine limitation, see @sqlaproxy for details
LAST_BY_CONNECTION = {}

def __init__(self, sqlaproxy, config, statement=None, conn=None):
Expand Down Expand Up @@ -706,12 +707,6 @@ def run(conn, sql, config):
if not is_dbapi_connection:
statement = sqlalchemy.sql.text(statement)

# TODO: duckdb does dot return a new cursor by default, so if we
# run conn.session.execute, all pending results from existing resultsets
# are lost. we need to warn the user about this. we can fix this by
# adding a flag to know if we need to re-run the query for outdated
# resultssets

result = conn.session.execute(statement)
_commit(conn=conn, config=config, manual_commit=manual_commit)

Expand Down

0 comments on commit ec6e9db

Please sign in to comment.