Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API version #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update API version #3

wants to merge 2 commits into from

Conversation

tarzzz
Copy link

@tarzzz tarzzz commented Dec 19, 2024

This updates the API version to 0.0.9

@tarzzz tarzzz requested a review from BRONSOLO December 19, 2024 15:08
BRONSOLO
BRONSOLO reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@BRONSOLO BRONSOLO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Are we making custom changes here? I see upstream is on v0.10. Could we sync with upstream here instead of this PR?

@tarzzz
Copy link
Author

tarzzz commented Jan 6, 2025

@BRONSOLO Could you remind me the process.
I have sync'd main-upstream.. what are the next steps..

@BRONSOLO
Copy link
Member

BRONSOLO commented Jan 7, 2025

This should be the flow: https://github.com/plotly/apt-buildpack?tab=readme-ov-file#plotly-release-flow.

Basically, if you could now:

  1. Open a PR against main from the main-upstream branch.
  2. Have that approved / merged
  3. Open a separate PR against the release branch to include these changes from main-upstream as well
  4. Have that approved / merged

Please let me know if you have any qs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BRONSOLO BRONSOLO BRONSOLO left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarzzz @BRONSOLO