Fixing secondary X and Y axis on subplots #2401
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #1203, fixing the issue by renaming the
overlayingaxis layout attribute as the X and Y axes are getting renamed.I added testthat, but I am not confident that I go the gist of it right.
This fix might break people's workarounds around this bug, where they set
overlayingto the already renamed name directly before calling the plot. I honestly have no idea how to fix this and keep the workarounds going, I do not think it is actually possible, so people would have to be warned not to apply their workarounds in a new version if this code makes it.I am behind corporate firewall so I was not able to run your Docker container just yet, I apologize. My hope is that this does not create any visual differences, because it would only fail if someone is testing specifically for the buggy dual Y axis subplot.