Merge pull request #74 from jealouscloud/pipeleak_fix

Fix a bug causing pipe FDs to leak

fabric/job_queue.py

@@ -148,7 +148,12 @@ def _advance_the_queue():
                         if self._debug:
                             print("Job queue found finished proc: %s." % job.name)
                         done = self._running.pop(id)
-                        self._completed.append(done)
+                        self._completed.append((done.name, done.exitcode))
+                        if hasattr(done, 'close') and callable(done.close):
+                            done.close()
+                        # multiprocessing.Process.close() added in Python-3.7
+                        # for older versions of python, GC will have to do
+                        del done
 
                 if self._debug:
                     print("Job queue has %d running." % len(self._running))
@@ -157,9 +162,6 @@ def _advance_the_queue():
                 if self._debug:
                     print("Job queue finished.")
 
-                for job in self._completed:
-                    job.join()
-
                 self._finished = True
 
             # Each loop pass, try pulling results off the queue to keep its
@@ -175,9 +177,9 @@ def _advance_the_queue():
         self._fill_results(results)
 
         # Attach exit codes now that we're all done & have joined all jobs
-        for job in self._completed:
+        for job_name, exit_code in self._completed:
             if isinstance(job, Process):
-                results[job.name]['exit_code'] = job.exitcode
+                results[job_name]['exit_code'] = exit_code
 
         return results