Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop check for base64 encoded strings #100

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Conversation

patrickrobrecht
Copy link
Member

@patrickrobrecht patrickrobrecht commented Mar 13, 2021

As the check does not work properly and the fix #95 still causes false positives, I propose to drop this check completely. Later we should implement a checksum-based check (#82).

This is an alternative to #95.

@stklcode stklcode added this to the 1.4.2 milestone Mar 13, 2021
@codecov-io
Copy link

codecov-io commented Mar 13, 2021

Codecov Report

Merging #100 (e07c38b) into develop (a704e09) will decrease coverage by 0.48%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #100      +/-   ##
=============================================
- Coverage      39.92%   39.43%   -0.49%     
+ Complexity       144      143       -1     
=============================================
  Files              5        5              
  Lines            541      535       -6     
=============================================
- Hits             216      211       -5     
+ Misses           325      324       -1     
Impacted Files Coverage Δ Complexity Δ
inc/class-antivirus-checkinternals.php 43.11% <0.00%> (-2.10%) 34.00 <0.00> (-1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a704e09...e07c38b. Read the comment docs.

Copy link
Contributor

@stklcode stklcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the dropping this check.

@stklcode stklcode merged commit 7c54789 into develop Mar 13, 2021
@stklcode stklcode deleted the fix/drop-base64-check branch March 13, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants