Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove trailing semicolon from .htaccess sample code #309

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: remove trailing semicolon from .htaccess sample code #309

merged 1 commit into from
Oct 8, 2024

Conversation

stklcode
Copy link
Contributor

@stklcode stklcode commented Oct 6, 2024 •
edited
Loading

Fix regression from #302 where &gt was replaced with > instead of > which makes the apache config syntactically invalid.

# BEGIN CACHIFY
<IfModule mod_rewrite.c>;
                        ^

Removing the semicolons should make the config valid again.

@stklcode
fix: remove trailing semicolon from .htaccess sample code (#309)
f13f8cb 
Likely a regression from replacing "&gt;" with ">" which makes the
apache config syntactically invalid. Removing the semicolons should make
the config valid again.
@stklcode stklcode self-assigned this Oct 6, 2024
@stklcode stklcode added the bug label Oct 6, 2024
@stklcode stklcode added this to the 2.4.0 milestone Oct 6, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stklcode stklcode changed the title fix: remove trailing semicolon from .htaccess sample code (#309) fix: remove trailing semicolon from .htaccess sample code Oct 6, 2024
@stklcode stklcode mentioned this pull request Oct 6, 2024
Merged
Zodiac1978
Zodiac1978 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@Zodiac1978 Zodiac1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stklcode stklcode merged commit f13f8cb into develop Oct 8, 2024
15 checks passed
@stklcode stklcode deleted the fix/htaccess branch October 8, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zodiac1978 Zodiac1978 Zodiac1978 approved these changes

Assignees

@stklcode stklcode

Labels
bug
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stklcode @Zodiac1978