-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: remove non-Linux support from all build paths #5941
Conversation
e495a87
to
eaa3fb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 12 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status: 12 of 13 files reviewed, all discussions resolved (waiting on @janekmi)
Please rebase. |
eaa3fb6
to
bb2c86b
Compare
bb2c86b
to
180c140
Compare
180c140
to
f6294c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Reviewable status: 6 of 13 files reviewed, all discussions resolved (waiting on @janekmi and @osalyk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 12 files at r1, 1 of 7 files at r3, 6 of 6 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 7 files at r3, 6 of 6 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5941 +/- ##
==========================================
- Coverage 70.14% 70.12% -0.02%
==========================================
Files 133 133
Lines 19568 19568
Branches 3261 3261
==========================================
- Hits 13726 13723 -3
- Misses 5842 5845 +3 |
f6294c9
to
d34357a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
d34357a
to
a2a7d34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 12 files at r1, all commit messages.
Reviewable status: 5 of 13 files reviewed, 1 unresolved discussion (waiting on @grom72 and @osalyk)
a discussion (no related file):
I contacted our customers just to make sure they won't be affected by this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 13 files reviewed, all discussions resolved (waiting on @grom72 and @osalyk)
a discussion (no related file):
Previously, janekmi (Jan Michalski) wrote…
I contacted our customers just to make sure they won't be affected by this change.
It is confirmed this change won't be a problem for our customers.
a2a7d34
to
e50e870
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 12 files at r1, 2 of 8 files at r6, 6 of 6 files at r7, 6 of 6 files at r9, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)
Signed-off-by: Tomasz Gromadzki <[email protected]>
Signed-off-by: Tomasz Gromadzki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 8 files at r6, 6 of 6 files at r9, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)
Remove files and compilation options irrelevant to supported compilation options.
Fixes: #5715
This change is