common: ansible_user support in ansible scripts

[grom72]

• ansible_user is undefined on a localhost with a local connection and needs to be always passed with --extra-vars
  https://radeksprta.eu/posts/ansible_user-is-undefined-on-localhost/
• several minor cleanups of Ansible scripts' documentation
• rename the testUser to a new_user

This PR is a replacement for #5955.

---

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.07%. Comparing base (9819db6) to head (9316218).
Report is 121 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6055   +/-   ##
=======================================
  Coverage   70.07%   70.07%           
=======================================
  Files         133      133           
  Lines       19563    19563           
  Branches     3261     3261           
=======================================
  Hits        13708    13708           
  Misses       5855     5855           

[osalyk]

Reviewed 2 of 3 files at r1, 1 of 3 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

[janekmi]

Reviewed 3 of 3 files at r1, 3 of 3 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @grom72)

---

utils/ansible/opensuse-setup.yml line 9 at r2 (raw file):

# in the README.md file.
#
# Below is an example of how to use this file localy:

Suggestion:

Below is an example of how to use this file locally:

---

utils/ansible/opensuse-setup.yml line 12 at r2 (raw file):

#
# a) comment out the first command:
# -hosts: "{{ host }}"

Suggestion:

# - hosts: "{{ host }}"

---

utils/ansible/rockylinux-setup.yml line 9 at r2 (raw file):

# in the README.md file.
#
# Below is an example of how to use this file localy:

Suggestion:

Below is an example of how to use this file locally:

---

utils/ansible/rockylinux-setup.yml line 12 at r2 (raw file):

#
# a) comment out the first command:
# -hosts: "{{ host }}"

Suggestion:

# - hosts: "{{ host }}"

---

utils/ansible/update-os.yml line 10 at r3 (raw file):

#
# Note: This playbook is designed to work as a composite action during test preparation steps.
# Local usage might cause imidiate system reboot.

Suggestion:

Local usage might cause an immediate system reboot.

[grom72]

Reviewable status: 0 of 6 files reviewed, 5 unresolved discussions (waiting on @janekmi and @osalyk)

---

utils/ansible/opensuse-setup.yml line 9 at r2 (raw file):

# in the README.md file.
#
# Below is an example of how to use this file localy:

Done.

---

utils/ansible/opensuse-setup.yml line 12 at r2 (raw file):

#
# a) comment out the first command:
# -hosts: "{{ host }}"

Done.

---

utils/ansible/rockylinux-setup.yml line 9 at r2 (raw file):

# in the README.md file.
#
# Below is an example of how to use this file localy:

Done.

---

utils/ansible/rockylinux-setup.yml line 12 at r2 (raw file):

#
# a) comment out the first command:
# -hosts: "{{ host }}"

Done.

---

utils/ansible/update-os.yml line 10 at r3 (raw file):

#
# Note: This playbook is designed to work as a composite action during test preparation steps.
# Local usage might cause imidiate system reboot.

Done.

[janekmi]

Reviewed 6 of 6 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

---

utils/ansible/update-os.yml line 10 at r5 (raw file):

#
# Note: This playbook is designed to work as a composite action during test preparation steps.
# Local usage might cause an immediate system reboot.

Nitpick but since you divided this change into three commits I believe this bit should be a part of the "common: ansible_user support in ansible scripts" rather than "common: ansible_user support in ansible scripts". Please fix.

[grom72]

Reviewed 5 of 6 files at r6, 1 of 3 files at r7, 5 of 5 files at r8, 6 of 6 files at r9, 3 of 3 files at r10.
Reviewable status: 1 of 6 files reviewed, 1 unresolved discussion (waiting on @janekmi)

---

utils/ansible/update-os.yml line 10 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Nitpick but since you divided this change into three commits I believe this bit should be a part of the "common: ansible_user support in ansible scripts" rather than "common: ansible_user support in ansible scripts". Please fix.

Done.

[grom72]

Reviewed 5 of 5 files at r11, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)

[grom72]

Reviewed 1 of 6 files at r5.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)

[janekmi]

Reviewed 1 of 3 files at r10, 5 of 5 files at r11, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)