Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: remove pmem.io workflow file and related #6089

Merged
merged 1 commit into from
May 21, 2024

Conversation

osalyk
Copy link
Contributor

@osalyk osalyk commented May 14, 2024

This change is Reviewable

@osalyk osalyk added sprint goal This pull request is part of the ongoing sprint no changelog Add to skip the changelog check on your pull request labels May 14, 2024
@osalyk osalyk requested review from grom72 and janekmi May 14, 2024 08:06
@grom72 grom72 changed the base branch from master to stable-2.1 May 20, 2024 12:33
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi and @osalyk)


doc/README line 9 at r1 (raw file):

If you're looking for documentation to
get you started using PMDK, start here: https://github.com/pmem/pmdk.
Developers new to PMDK are probably looking for libpmemobj.

I think we should leave the reference to pmem.io/pmdk as we do not have any other general documentation about PMDK

Code quote:

get you started using PMDK, start here: https://github.com/pmem/pmdk.
Developers new to PMDK are probably looking for libpmemobj.

src/examples/README line 31 at r1 (raw file):

libpmem2(7) -- low-level persistent memory support
    Example programs are in the libpmem2 directory.
    More documentation: https://github.com/pmem/pmdk/tree/master/src/libpmem2

Examples' documentation on pmem.io is OK (we do not have an alternative).

Code quote:

If you're looking for documentation to get you started using PMDK,
start here: https://github.com/pmem/pmdk and follow the links to examples and
man pages.  Developers new to PMDK are probably looking for libpmemobj.

Many of the examples in this directory are described in more detail
on the above web site.

libpmem(7) -- low-level persistent memory support
    Example programs are in the libpmem directory.
    More documentation: https://github.com/pmem/pmdk/tree/master/src/libpmem

libpmemobj(7) -- transactional object store
    Example programs are in the libpmemobj directory.
    More documentation: https://github.com/pmem/pmdk/tree/master/src/libpmemobj

libpmempool(7) -- pool management, diagnostics and repair
    Example programs are in the libpmempool directory.
    More documentation: https://github.com/pmem/pmdk/tree/master/src/libpmempool

libpmem2(7) -- low-level persistent memory support
    Example programs are in the libpmem2 directory.
    More documentation: https://github.com/pmem/pmdk/tree/master/src/libpmem2

Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 11 of 14 files reviewed, 2 unresolved discussions (waiting on @grom72 and @janekmi)


doc/README line 9 at r1 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

I think we should leave the reference to pmem.io/pmdk as we do not have any other general documentation about PMDK

Done.


src/examples/README line 31 at r1 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Examples' documentation on pmem.io is OK (we do not have an alternative).

Done.

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 14 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @grom72)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

@janekmi janekmi merged commit b5cb466 into pmem:stable-2.1 May 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants