Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing log_internal.h to fix build on aarch64 #6096

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

ggardet
Copy link
Contributor

@ggardet ggardet commented Jun 6, 2024

Fixes #6088


This change is Reviewable

Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ggardet)

@grom72 grom72 added the no changelog Add to skip the changelog check on your pull request label Jun 7, 2024
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ggardet)

@osalyk
Copy link
Contributor

osalyk commented Jun 11, 2024

@ggardet Push in the changes again please. We have a check for an updated changelog file. If there is not then there should be a corresponding label (Tomasz added this label).

Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ggardet)

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ggardet)

@janekmi janekmi merged commit 976ec03 into pmem:master Jun 14, 2024
7 checks passed
@janekmi janekmi added this to the 2.1.1 milestone Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation error under arrach64
4 participants