-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: introduce a test reproducing the #5583 (fix 2) #6099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)
src/test/obj_ulog_advanced/obj_ulog_advanced.c
line 20 at r2 (raw file):
#if VG_PMEMCHECK_ENABLED == 0 #define VALGRIND_PMC_EMIT_LOG(_) /* NOP */
Do we need this if test are not run with valgrind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72 and @osalyk)
src/test/obj_ulog_advanced/obj_ulog_advanced.c
line 20 at r2 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
Do we need this if test are not run with valgrind?
Bash-based tests use pmemcheck.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
Disable memcheck, helgrind, drd and pmemcheck for the Python-based tests. Signed-off-by: Jan Michalski <[email protected]>
Requires:
Preview: https://github.com/pmem/pmdk/actions/runs/9513026651
This change is