-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: update files for updating repositories #6101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @osalyk)
.github/workflows/pmem_ras.yml
line 45 at r1 (raw file):
uses: actions/checkout@v4 # Variables, such as $ras_runner are hidden on the controller platform as environmental variables.
They are not longer hidden. And they never were environmentAL variables. 😆
Suggestion:
# Variables, such as $ras_runner are set on the controller platform as environment variables.
.github/workflows/pmem_ras.yml
line 47 at r1 (raw file):
# Variables, such as $ras_runner are hidden on the controller platform as environmental variables. # 'sed' command is used to filter out IP addresses from the ansible output, it will show up as the 'ras_runner' instead. # 'tee' command is used to save the overall output to the file. This file is needed for the next step.
utils/gha-runners/run-ras-linux.yml
line 178 at r1 (raw file):
# The 'Main' branch is used for both repositories. - name: "Ensure working directory exists"
Suggestion:
"Ensure the working directory exists"
utils/gha-runners/run-ras-linux.yml
line 183 at r1 (raw file):
state: directory - name: "Remove existing PMDK repository if present"
"Existing if present". You cannot have one without another. There are no nonexistent but present entities.
I believe the conditional part is key.
Suggestion:
"Remove the PMDK repository if present"
utils/gha-runners/run-ras-linux.yml
line 189 at r1 (raw file):
force: yes - name: "Remove existing PMDK-test repository if present"
.
Code quote:
"Remove existing PMDK-test repository if present"
utils/gha-runners/run-ras-linux.yml
line 195 at r1 (raw file):
force: yes - name: "Clone PMDK & PMDK-test repositories"
Suggestion:
"Clone the PMDK & PMDK-test repositories"
867d4b4
to
0a8c25a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 6 unresolved discussions (waiting on @janekmi)
.github/workflows/pmem_ras.yml
line 45 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
They are not longer hidden. And they never were environmentAL variables. 😆
Done.
.github/workflows/pmem_ras.yml
line 47 at r1 (raw file):
# Variables, such as $ras_runner are hidden on the controller platform as environmental variables. # 'sed' command is used to filter out IP addresses from the ansible output, it will show up as the 'ras_runner' instead. # 'tee' command is used to save the overall output to the file. This file is needed for the next step.
Done.
utils/gha-runners/run-ras-linux.yml
line 178 at r1 (raw file):
# The 'Main' branch is used for both repositories. - name: "Ensure working directory exists"
Done.
utils/gha-runners/run-ras-linux.yml
line 183 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
"Existing if present". You cannot have one without another. There are no nonexistent but present entities.
I believe the conditional part is key.
Done.
utils/gha-runners/run-ras-linux.yml
line 189 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
.
Done.
utils/gha-runners/run-ras-linux.yml
line 195 at r1 (raw file):
force: yes - name: "Clone PMDK & PMDK-test repositories"
Done.
0a8c25a
to
1b872fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let me know when you would like to see it landed.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)
This change is