Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: fix typo in pmem_tests.yml file #6104

Merged
merged 1 commit into from
Jul 31, 2024
Merged

common: fix typo in pmem_tests.yml file #6104

merged 1 commit into from
Jul 31, 2024

Conversation

osalyk
Copy link
Contributor

@osalyk osalyk commented Jul 26, 2024

@osalyk osalyk added the no changelog Add to skip the changelog check on your pull request label Jul 26, 2024
@osalyk osalyk requested review from grom72 and janekmi July 26, 2024 07:17
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)

a discussion (no related file):
Can we also fix the pmem_test_prepare action with the following checker:

- run: |
    [[ "${{ inputs.valgrind}}" ]] || { echo "valgrind input is empty" ; exit 1; }

@osalyk osalyk force-pushed the typo branch 2 times, most recently from 97df90f to d566450 Compare July 26, 2024 09:18
Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)

a discussion (no related file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Can we also fix the pmem_test_prepare action with the following checker:

- run: |
    [[ "${{ inputs.valgrind}}" ]] || { echo "valgrind input is empty" ; exit 1; }

https://github.com/pmem/pmdk/actions/runs/10108819271/job/27955490804


Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)


.github/actions/pmem_test_prepare/action.yml line 44 at r3 (raw file):

        $WORKDIR/build-pmdk.sh
        echo '::endgroup::'
        [[ "${{ inputs.valgrind }}" ]] || { echo "valgrind input is empty" ; exit 1; }

Let's make input validation the first step.

Suggestion:

        echo '::group::Validate input'
        [[ "${{ inputs.valgrind }}" ]] || { echo "valgrind input is empty" ; exit 1; }
        echo '::endgroup::'
        echo '::group::Build'
        $WORKDIR/build-pmdk.sh
        echo '::endgroup::'

Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)


.github/actions/pmem_test_prepare/action.yml line 44 at r3 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Let's make input validation the first step.

Done.

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Copy link

@jzarzycki jzarzycki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@osalyk osalyk merged commit 7ac4c17 into pmem:master Jul 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants