we don't need a fake server instance outside of setUp() in these tests

pmmp · Nov 20, 2024 · d9080f1 · d9080f1
1 parent d9f5634
commit d9080f1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/tests/phpunit/event/AsyncEventConcurrencyTest.php b/tests/phpunit/event/AsyncEventConcurrencyTest.php
@@ -35,8 +35,6 @@
 final class AsyncEventConcurrencyTest extends TestCase{
 
 	private Plugin $mockPlugin;
-	private Server $mockServer;
-
 	private PluginManager $pluginManager;
 
 	//this one gets its own class because it requires a bunch of context variables
@@ -57,10 +55,10 @@ protected function setUp() : void{
 
 		//TODO: this is a really bad hack and could break any time if PluginManager decides to access its Server field
 		//we really need to make it possible to register events without a Plugin or Server context
-		$this->mockServer = $this->createMock(Server::class);
+		$mockServer = $this->createMock(Server::class);
 		$this->mockPlugin = self::createStub(Plugin::class);
 		$this->mockPlugin->method('isEnabled')->willReturn(true);
-		$this->pluginManager = new PluginManager($this->mockServer, null);
+		$this->pluginManager = new PluginManager($mockServer, null);
 	}
 
 	public static function tearDownAfterClass() : void{

diff --git a/tests/phpunit/event/AsyncEventTest.php b/tests/phpunit/event/AsyncEventTest.php
@@ -35,8 +35,6 @@
 use function shuffle;
 
 final class AsyncEventTest extends TestCase{
-
-	private Server $mockServer;
 	private Plugin $mockPlugin;
 	private PluginManager $pluginManager;
 
@@ -45,10 +43,10 @@ protected function setUp() : void{
 
 		//TODO: this is a really bad hack and could break any time if PluginManager decides to access its Server field
 		//we really need to make it possible to register events without a Plugin or Server context
-		$this->mockServer = $this->createMock(Server::class);
+		$mockServer = $this->createMock(Server::class);
 		$this->mockPlugin = self::createStub(Plugin::class);
 		$this->mockPlugin->method('isEnabled')->willReturn(true);
-		$this->pluginManager = new PluginManager($this->mockServer, null);
+		$this->pluginManager = new PluginManager($mockServer, null);
 	}
 
 	public static function tearDownAfterClass() : void{