Massive block's hardness & blast resistance update

[IvanCraft623]

Introduction

It is important to keep these values up to date, not only for vanilla-parity, anti-cheats may also depend on them.

Follow-up

Add a file to bedrock-data that contains block's hardness & blast resistance values, to be able to make a PHPUnit test.

Tests

I tested this PR by doing the following (tick all that apply):

• Writing a test plugin (provide the code and sample output)

Vanilla hardness & blast resistance values(need to be droped in plugin_data) file: blocks_hardness.json
(File was provided by @TwistedAsylumMC)

Code:

public function onEnable() : void {
	$ignoredStates = [
		"minecraft:air" => true,
		"minecraft:barrier" => true,
		"minecraft:flowing_lava" => true, //destructible in vanilla???
		"minecraft:flowing_water" => true, //destructible in vanilla???
		"minecraft:light_block" => true,
	];

	$blocksData = json_decode(file_get_contents($this->getDataFolder() . "blocks_hardness.json"), true);
	$serializer = GlobalBlockStateHandlers::getSerializer();
	foreach (VanillaBlocks::getAll() as $block) {
		$stateName = $serializer->serialize($block->getStateId())->getName();
		if (isset($ignoredStates[$stateName])) {
			continue;
		}
		foreach ($blocksData as $blockData) {
			if ($blockData["id"] !== $stateName) {
				continue;
			}
			$breakInfo = $block->getBreakInfo();
			$hardness = round($blockData["base_hardness"], 5);
			$blastResistance = round($blockData["blast_resistance"], 5) * 5;
			if ($hardness != $breakInfo->getHardness() ||
				$blastResistance != $breakInfo->getBlastResistance()
			) {
				$this->getLogger()->warning(
					"\n\nBlock(" . $block->getName() . ", class: " . basename(str_replace('\\', '/', $block::class)) . ", stateName: $stateName) has a mismatch hardness:\n" .
					"PM hardness: " . $breakInfo->getHardness() . "\n" .
					"PM blast_resistance: " . $breakInfo->getBlastResistance() . "\n" .
					"Vanilla hardness: " . $hardness . "\n" .
					"Vanilla blast_resistance: " . $blastResistance
				);
			}
			continue 2;
		}
		$this->getLogger()->error("Block with state id $stateName not found");
	}
	$this->getLogger()->info("Finished hardness test!");
}

Sample output:

[18:48:36.004] [Server thread/ERROR]: [Test] Block with state id minecraft:tube_coral_block not found
[18:48:36.004] [Server thread/ERROR]: [Test] Block with state id minecraft:sunflower not found
[18:48:36.004] [Server thread/ERROR]: [Test] Block with state id minecraft:lilac not found
[18:48:36.005] [Server thread/ERROR]: [Test] Block with state id minecraft:rose_bush not found
[18:48:36.005] [Server thread/ERROR]: [Test] Block with state id minecraft:peony not found
[18:48:36.005] [Server thread/ERROR]: [Test] Block with state id minecraft:tall_grass not found
[18:48:36.005] [Server thread/ERROR]: [Test] Block with state id minecraft:large_fern not found
[18:48:36.009] [Server thread/ERROR]: [Test] Block with state id minecraft:brick_slab not found
[18:48:36.009] [Server thread/ERROR]: [Test] Block with state id minecraft:cobblestone_slab not found
[18:48:36.009] [Server thread/ERROR]: [Test] Block with state id minecraft:petrified_oak_slab not found
[18:48:36.009] [Server thread/ERROR]: [Test] Block with state id minecraft:nether_brick_slab not found
[18:48:36.010] [Server thread/ERROR]: [Test] Block with state id minecraft:quartz_slab not found
[18:48:36.010] [Server thread/ERROR]: [Test] Block with state id minecraft:sandstone_slab not found
[18:48:36.010] [Server thread/ERROR]: [Test] Block with state id minecraft:smooth_stone_slab not found
[18:48:36.010] [Server thread/ERROR]: [Test] Block with state id minecraft:stone_brick_slab not found
[18:48:36.023] [Server thread/INFO]: [Test] Finished hardness test!

Currently it seems that doesn't have some blocks mapped

[ShockedPlot7560]

What is the source of the file? Do we know what it was generated from?

[IvanCraft623]

What is the source of the file? Do we know what it was generated from?

It was provided to me by @TwistedAsylumMC, was generated through a mod

[ShockedPlot7560]

That sounds fine to me if all the values are correct and the source is reliable.

[IvanCraft623]

Some values are still outdated due to changes on recent MCBE versions