Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a sound when drinking a potion #6444

Open
wants to merge 2 commits into
base: minor-next
Choose a base branch
from
Open

Implement a sound when drinking a potion #6444

wants to merge 2 commits into from

Conversation

ipad54
Copy link
Contributor

@ipad54 ipad54 commented Sep 4, 2024 •
edited
Loading

Introduction

This sound is played in vanilla when player drinks a potion.

Changes

API changes

Added BottleEmptySound.

Tests

I tested this PR by doing the following:

@ShockedPlot7560 ShockedPlot7560 added Category: Gameplay Related to Minecraft gameplay experience Type: Fix Bug fix, typo fix, or any other fix Type: Enhancement Contributes features or other improvements to PocketMine-MP and removed Type: Fix Bug fix, typo fix, or any other fix labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dries-c dries-c dries-c approved these changes

@ShockedPlot7560 ShockedPlot7560 ShockedPlot7560 approved these changes

Assignees
No one assigned
Labels
Category: Gameplay Related to Minecraft gameplay experience Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipad54 @dries-c @ShockedPlot7560