Regeneration 5 => 2 matching Java #6445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholass003
reviewed
Sep 5, 2024
src/item/GoldenAppleEnchanted.php
Outdated
| @@ -30,7 +30,7 @@ class GoldenAppleEnchanted extends GoldenApple{ | |||
|
|
|||
| public function getAdditionalEffects() : array{ | |||
| return [ | |||
| new EffectInstance(VanillaEffects::REGENERATION(), 600, 4), | |||
| new EffectInstance(VanillaEffects::REGENERATION(), 600, 2), | |||
There was a problem hiding this comment.
the amplifier value should be 1, according to this
https://github.com/pmmp/PocketMine-MP/blob/stable/src/entity/effect/EffectInstance.php#L100
changelogs: https://feedback.minecraft.net/hc/en-us/articles/29937458432397-Minecraft-Beta-Preview-1-21-40-20
There was a problem hiding this comment.
I see it already applied 1 level so when a user inputs 0 it’ll automatically be 1.
ShockedPlot7560
added
Category: Gameplay
dktapps
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
In recent updates the Enchanted Golden Apple has been nerfed to match Java edition
Relevant issues
Changes
API changes
Nerfed Enchanted Golden Apple to match Java edition
Behavioural changes
No since it only affects 1 item
Backwards compatibility
Follow-up
Tests
I tested this PR by doing the following (tick all that apply):
tests/phpunitfolder)