Fixed server crash when applying a cooldown to any item with 1 count #6491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes server crash when applying a cooldown to any item which count is equals to 1.
dktapps
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This was introduced in #6405
The crash happens because
ItemSerializercan not serialize an item with 0 count inonItemCooldownChanged(). This can happen when you have 1 ender pearl sinceresetItemCooldown()is called only after a successful item usage, so ender pearl count is already decreased at this stage.Relevant issues
#6490
#6488
Tests
https://www.youtube.com/watch?v=KSZC6mmEGk4