fix: portal material visible default to false #1914
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Issue: performance issue with many MeshPortalMaterial. MeshPortalMaterial
visible
variable is never set tofalse
without specific interactions.MeshPortalMaterial is using a variable
visible
which decides if the texture needs to be updated or not. This variable value istrue
by default and is updated usinguseIntersect
.When a scene uses many MeshPortalMaterial they are all getting updated on each frame, until the camera moves around to look at the portals and then look away. This triggers the
useIntersect
hook which setvisible
totrue
when the portal is on sight, and then back tofalse
when it's not on sight anymore.What
Set
visible
tofalse
by default.Checklist