Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: portal material visible default to false #1914

Conversation

justabayet
Copy link

Why

Issue: performance issue with many MeshPortalMaterial. MeshPortalMaterial visible variable is never set to false without specific interactions.

MeshPortalMaterial is using a variable visible which decides if the texture needs to be updated or not. This variable value is true by default and is updated using useIntersect.

When a scene uses many MeshPortalMaterial they are all getting updated on each frame, until the camera moves around to look at the portals and then look away. This triggers the useIntersect hook which set visible to true when the portal is on sight, and then back to false when it's not on sight anymore.

What

Set visible to false by default.

Checklist

  • Ready to be merged

Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2024 5:42pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

Thank you for your work on this pull request! We’re marking this PR as stale to encourage a final push to bring it across the finish line.

Any update, comment, or change to the PR will automatically remove the stale label so it stays active in our workflow.

If you need any help, don’t hesitate to connect with us on Discord for feedback and support. This PR will close automatically soon if there’s no further activity, but we’re here to help if you’re interested in getting it merged. Thank you for your contribution!

@github-actions github-actions bot added the Stale Inactive issue label Oct 30, 2024
Copy link

github-actions bot commented Nov 8, 2024

We’re closing this pull request to help manage our workload and focus on active contributions. We really appreciate the effort you put into this, and we’d be happy to revisit it anytime you’re ready.

Please feel free to re-open this PR or reach out on Discord if you’d like to continue — our community is always here to support you. Thanks again for your contribution and for helping us stay organized!

@github-actions github-actions bot closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Inactive issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant