[feat] update for R3F v9 #1941
[feat] update for R3F v9 #1941
Conversation
# Conflicts: # src/core/Environment.tsx # src/core/useEnvironment.tsx
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@joshuaellis I'd like to appeal to you about upgrading |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Now builds. Known issues are with components that access R3F internals like |
Sorry I missed this. Do you know what the impact looks like? I can probably find some time for you haha |
I believe it is just types, maybe related to this: https://react.dev/blog/2024/04/25/react-19-upgrade-guide#the-jsx-namespace-in-typescript We also moved types for R3F to |
# Conflicts: # src/core/Text.tsx
Co-authored-by: Cody Bennett <[email protected]>
This reverts commit 482cc39.
|
@CodyJasonBennett I'm stuck again getting the test to run. Some kind of source map issue. |
Co-authored-by: Cody Bennett <[email protected]>
|
Thank you for your work on this pull request! We’re marking this PR as stale to encourage a final push to bring it across the finish line. Any update, comment, or change to the PR will automatically remove the stale label so it stays active in our workflow. If you need any help, don’t hesitate to connect with us on Discord for feedback and support. This PR will close automatically soon if there’s no further activity, but we’re here to help if you’re interested in getting it merged. Thank you for your contribution! |
|
We’re closing this pull request to help manage our workload and focus on active contributions. We really appreciate the effort you put into this, and we’d be happy to revisit it anytime you’re ready. Please feel free to re-open this PR or reach out on Discord if you’d like to continue — our community is always here to support you. Thanks again for your contribution and for helping us stay organized! |
This is untested. It is a quick conversion of Drei v9 to use R3F v9 without any typing errors.