fix: 1966 View respects manual ortho camera #1991
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
View.tsx is changed for bug #1966. A the frustum of an orthographic camera was reset to the default position even when the camera was manual. The user's manual setting (for example to do a full-frame view) was thus overwritten.
What
After checking that the camera is Orthographic, the code now checks if state.camera.manual is set. If not the old code is executed. Otherwise just update the projection matrix. NOT SURE THIS IS NEEDED
Checklist
Not sure what the right next step is.