-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Line accepts readonly points and vertex colors #2055
fix: Line accepts readonly points and vertex colors #2055
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
7a40d54
to
9f11306
Compare
I think the image snapshot test is failing due to an update to the test docker image. |
ah yes, missed that, will fix |
should be fixed |
@RodrigoHamuy is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
🎉 This PR is included in version 9.112.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Why
Currently this will give TS errors:
What
Updated the types so it accepts also readonly arrays.
This doesn't mean that you need to pass immutable arrays now, just means that
<Line>
promises it won't change the receiving arrays.Checklist