fix: Use deepscan to detect basic code smells #2064
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Main repo
Three.js
started to use Deepscan website to improve their code base quality.What
I just for this repo and tried to fix some minor code smells, mostly unusued imports.
See all the possible code smells here : https://deepscan.io/dashboard/#view=project&tid=24491&pid=27702&bid=889307&prid=&subview=issues&page=1
I didn't fix some of the most interesting ones as I don't know the expected behaviour, see issues such as this one : https://deepscan.io/dashboard/#view=project&pid=27702&iid=202651872&tid=24491&subview=issues&bid=889307
Checklist