Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use deepscan to detect basic code smells #2064

Closed
wants to merge 1 commit into from

Conversation

s-rigaud
Copy link

@s-rigaud s-rigaud commented Aug 12, 2024

Why

Main repo Three.js started to use Deepscan website to improve their code base quality.

What

I just for this repo and tried to fix some minor code smells, mostly unusued imports.
See all the possible code smells here : https://deepscan.io/dashboard/#view=project&tid=24491&pid=27702&bid=889307&prid=&subview=issues&page=1

I didn't fix some of the most interesting ones as I don't know the expected behaviour, see issues such as this one : https://deepscan.io/dashboard/#view=project&pid=27702&iid=202651872&tid=24491&subview=issues&bid=889307

Checklist

  • Documentation updated (example)
  • Storybook entry added (example)
  • Ready to be merged

Copy link

vercel bot commented Aug 12, 2024

@s-rigaud is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@joshuaellis
Copy link
Member

I think we'd rather use eslint to solve this issue, if we update the config correctly we can avoid unused exports, i think the rest of the changes are more opinionated, but thank you for taking the time to make this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants