add test for unstable_derive #2665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/4ZT5HFS7X |
See documentations for usage instructions.
dai-shi
approved these changes
Jul 19, 2024
dai-shi
added a commit
that referenced
this pull request
Aug 13, 2024
* experimental(core): expose unstable_derive instead of unstable_is * chore: remove empty line * chore types * follow resolveAtom in #2609 * store test from #2609 * adjust store.test.tsx for unstable_derive * limit atom state map type * add test with atom state map * update test using unstable_derive * drop resolveAtom, add derive atom test * simplify unstable_derive * wip: this works but i do not like it * separate atomstate and atomcontext * for old ts * fix * fix 2 * simplify a bit with dev breaking changes * revert to bd9c6c0, except for new test * refactor (skipping the new test for now) * refactor 2 * revert those refactors :-p * wip: hm, how is bundle size? * fix tests * add test for unstable_derive (#2665) * add a failing test * wip: failed attempt * split unstable_derive test * wip: failed attempt 2 * revert failing tests * empty commit * restore unstable_is of now (we will remove it in the later version.) --------- Co-authored-by: David Maskasky <[email protected]> Co-authored-by: David Maskasky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds test for unstable_derive store api.
This new case tests both read and write for the combination of scoped and unscoped derived atoms indicated by the above configuration.
aandbare primitive atoms.c,d, andeare derived atoms.cdepends ona,ddepends onc, andedepends ondandb.dis explicitly scoped.dis explicitly scoped, its dependencycis implicitly scoped.c's dependencyais also implicitly scoped.eis not scoped,ecan read both explicitly scoped and not scoped dependenciesdandb.Check List
pnpm run prettierfor formatting code and docs