Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unstable_derive): trap atom methods #2741

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Sep 19, 2024

This enables to trap atom.read, atom.write and atom.onMount.
This eliminates originAtomState for getAtomState.

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 3:27am

Copy link

codesandbox-ci bot commented Sep 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented Sep 19, 2024

Size Change: +392 B (+0.44%)

Total Size: 89.3 kB

Filename Size Change
./dist/esm/vanilla.mjs 3.69 kB +3 B (+0.08%)
./dist/system/vanilla.development.js 3.77 kB +3 B (+0.08%)
./dist/system/vanilla.production.js 1.99 kB +15 B (+0.76%)
./dist/umd/vanilla.development.js 5 kB +179 B (+3.71%)
./dist/umd/vanilla.production.js 2.68 kB +14 B (+0.52%)
./dist/vanilla.js 4.9 kB +178 B (+3.77%)
ℹ️ View Unchanged
Filename Size
./dist/babel/plugin-debug-label.js 932 B
./dist/babel/plugin-react-refresh.js 1.14 kB
./dist/babel/preset.js 1.41 kB
./dist/esm/babel/plugin-debug-label.mjs 1 kB
./dist/esm/babel/plugin-react-refresh.mjs 1.19 kB
./dist/esm/babel/preset.mjs 1.49 kB
./dist/esm/index.mjs 62 B
./dist/esm/react.mjs 1.4 kB
./dist/esm/react/utils.mjs 746 B
./dist/esm/utils.mjs 67 B
./dist/esm/vanilla/utils.mjs 5.03 kB
./dist/index.js 242 B
./dist/react.js 1.44 kB
./dist/react/utils.js 1.39 kB
./dist/system/babel/plugin-debug-label.development.js 1.1 kB
./dist/system/babel/plugin-debug-label.production.js 775 B
./dist/system/babel/plugin-react-refresh.development.js 1.29 kB
./dist/system/babel/plugin-react-refresh.production.js 928 B
./dist/system/babel/preset.development.js 1.59 kB
./dist/system/babel/preset.production.js 1.14 kB
./dist/system/index.development.js 252 B
./dist/system/index.production.js 183 B
./dist/system/react.development.js 1.56 kB
./dist/system/react.production.js 863 B
./dist/system/react/utils.development.js 860 B
./dist/system/react/utils.production.js 462 B
./dist/system/utils.development.js 257 B
./dist/system/utils.production.js 187 B
./dist/system/vanilla/utils.development.js 5.24 kB
./dist/system/vanilla/utils.production.js 3.15 kB
./dist/umd/babel/plugin-debug-label.development.js 1.08 kB
./dist/umd/babel/plugin-debug-label.production.js 852 B
./dist/umd/babel/plugin-react-refresh.development.js 1.27 kB
./dist/umd/babel/plugin-react-refresh.production.js 1 kB
./dist/umd/babel/preset.development.js 1.54 kB
./dist/umd/babel/preset.production.js 1.22 kB
./dist/umd/index.development.js 383 B
./dist/umd/index.production.js 328 B
./dist/umd/react.development.js 1.56 kB
./dist/umd/react.production.js 934 B
./dist/umd/react/utils.development.js 1.53 kB
./dist/umd/react/utils.production.js 1.01 kB
./dist/umd/utils.development.js 399 B
./dist/umd/utils.production.js 342 B
./dist/umd/vanilla/utils.development.js 6.24 kB
./dist/umd/vanilla/utils.production.js 3.79 kB
./dist/utils.js 247 B
./dist/vanilla/utils.js 6.11 kB

compressed-size-action

Copy link

github-actions bot commented Sep 19, 2024

LiveCodes Preview in LiveCodes

Latest commit: 7601858
Last updated: Nov 9, 2024 3:25am (UTC)

Playground Link
React demo https://livecodes.io?x=id/4C8MBEQP5

See documentations for usage instructions.

* fix(unstable_derive): add tests

* test(unstable_derive): add failing test
@dai-shi dai-shi changed the title fix(unstable_derive): expose atomRead and atomWrite fix(unstable_derive): trap atom methods Oct 1, 2024
src/vanilla/store.ts Outdated Show resolved Hide resolved
@dmaskasky
Copy link
Collaborator

I like the atomOnMount trap.

I'm not sure about removing originalAtomState just yet though. It could be important for jotai-scope if it could be used to reliably resolve atomState. Earlier implementation was consistent for readAtomState and writeAtomState, but inconsistent / missing in other cases such as subscribe.

Co-authored-by: David Maskasky <[email protected]>
@dai-shi
Copy link
Member Author

dai-shi commented Nov 9, 2024

I'm not sure about removing originalAtomState just yet though.

As it's technically impossible to solve missing cases, I think it was an insufficient idea. Let's drop it and merge this.

@dai-shi dai-shi marked this pull request as ready for review November 9, 2024 03:25
@dai-shi dai-shi added this to the v2.10.2 milestone Nov 9, 2024
@dmaskasky
Copy link
Collaborator

As it's technically impossible to solve missing cases, I think it was an insufficient idea. Let's drop it and merge this.

Yes I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants