Skip to content

Commit

Permalink
chore: enable isolatedDeclarations (#2738)
Browse files Browse the repository at this point in the history
  • Loading branch information
dai-shi authored Sep 15, 2024
1 parent fec9135 commit 88ee69f
Show file tree
Hide file tree
Showing 5 changed files with 48 additions and 43 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/test-old-typescript.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ jobs:
cache-dependency-path: '**/pnpm-lock.yaml'
- run: pnpm install --frozen-lockfile
- run: pnpm build
- name: Patch for all TS
run: |
sed -i~ 's/"isolatedDeclarations": true,//' tsconfig.json
- name: Patch for v4/v3 TS
if: ${{ startsWith(matrix.typescript, '4.') || startsWith(matrix.typescript, '3.') }}
run: |
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@
"rollup-plugin-esbuild": "^6.1.1",
"shelljs": "^0.8.5",
"shx": "^0.3.4",
"typescript": "^5.5.4",
"typescript": "^5.6.2",
"use-sync-external-store": "^1.2.2",
"vitest": "^2.0.5"
},
Expand Down
82 changes: 41 additions & 41 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/test-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const replacer = (
}
}

export const reviver = (key: string, value: ReplacedMap | unknown) => {
export const reviver = (key: string, value: ReplacedMap | unknown): unknown => {
if (isReplacedMap(value)) {
return new Map(value.value)
}
Expand Down
2 changes: 2 additions & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
"noUncheckedIndexedAccess": true,
"exactOptionalPropertyTypes": true,
"verbatimModuleSyntax": true,
"declaration": true,
"isolatedDeclarations": true,
"noEmit": true,
"baseUrl": ".",
"paths": {
Expand Down

0 comments on commit 88ee69f

Please sign in to comment.