Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shallow): iterable-like insensitive keys order comparison #2816

Closed
wants to merge 13 commits into from

Conversation

dbritto-dev
Copy link
Collaborator

Related Bug Reports or Discussions

Fixes #2808

Summary

#2808

Check List

  • pnpm run prettier for formatting code and docs

@dbritto-dev dbritto-dev added the enhancement New feature or request label Oct 24, 2024
@dbritto-dev dbritto-dev requested a review from dai-shi October 24, 2024 23:54
@dbritto-dev dbritto-dev self-assigned this Oct 24, 2024
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 7:55am

Copy link

codesandbox-ci bot commented Oct 24, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dbritto-dev dbritto-dev changed the title feat: update shallow util and tests fix(shallow): iterable-like insensitive keys order comparison Oct 25, 2024
@dbritto-dev
Copy link
Collaborator Author

dbritto-dev commented Oct 25, 2024

Size Change: -267 B (-2.23%)

Total Size: 11.7 kB

Filename Size Change
./dist/esm/vanilla/shallow.mjs 433 B -134 B (-23.63%) 🎉
./dist/vanilla/shallow.js 448 B -133 B (-22.89%) 🎉
ℹ️ View Unchanged
Filename Size
./dist/esm/index.mjs 64 B
./dist/esm/middleware.mjs 3.56 kB
./dist/esm/middleware/immer.mjs 210 B
./dist/esm/react.mjs 320 B
./dist/esm/react/shallow.mjs 193 B
./dist/esm/shallow.mjs 82 B
./dist/esm/traditional.mjs 411 B
./dist/esm/vanilla.mjs 403 B
./dist/index.js 244 B
./dist/middleware.js 3.56 kB
./dist/middleware/immer.js 229 B
./dist/react.js 336 B
./dist/react/shallow.js 208 B
./dist/shallow.js 189 B
./dist/traditional.js 423 B
./dist/vanilla.js 416 B

compressed-size-action

All done!

tests/vanilla/shallow.test.tsx Outdated Show resolved Hide resolved
src/vanilla/shallow.ts Outdated Show resolved Hide resolved
src/vanilla/shallow.ts Show resolved Hide resolved
@dbritto-dev dbritto-dev changed the title fix(shallow): iterable-like insensitive keys order comparison fix(shallow): iterable-like keys ordered comparison Oct 26, 2024
@dbritto-dev dbritto-dev changed the title fix(shallow): iterable-like keys ordered comparison fix(shallow): iterable-like insensitive keys order comparison Oct 26, 2024
@dbritto-dev
Copy link
Collaborator Author

@dai-shi all yours

@dbritto-dev
Copy link
Collaborator Author

Close in favor of #2821

@dbritto-dev dbritto-dev deleted the update-shallow branch October 28, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants