Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.github/workflows/test-multiple-versions.yml): improve workflow with removing duplicated configs #2920

Merged

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Dec 19, 2024

Summary

Check List

  • pnpm run prettier for formatting code and docs

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 4:46pm

Copy link

codesandbox-ci bot commented Dec 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Dec 19, 2024

Open in Stackblitzdemo

npm i https://pkg.pr.new/zustand@2920

commit: 1bec6bb

@sukvvon sukvvon force-pushed the chore/add-cache-dependency-path-for-restore-cache branch from 274261b to 1bec6bb Compare December 19, 2024 16:45
@sukvvon sukvvon changed the title chore(.github/workflows): add 'cache-dependency-path' in 'actions/setup-node' for restoring 'pnpm' cache chore(.github/workflows/test-multiple-versions.yml): improve workflow with removing duplicated configs Dec 19, 2024
@dai-shi
Copy link
Member

dai-shi commented Dec 20, 2024

Yeah, I noticed that too while working on pmndrs/jotai#2878.

Thanks!

@dai-shi dai-shi merged commit 5d92ad2 into pmndrs:main Dec 20, 2024
28 checks passed
@sukvvon sukvvon deleted the chore/add-cache-dependency-path-for-restore-cache branch December 20, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants