misc: Fix warnings from NVHPC compilers #7253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test:mpich/ch4/most |
raffenet
force-pushed
the
nvhpc-warnings
branch
from
e084fa0 to
ef0474f
Compare
|
test:mpich/ch4/most |
libpmi functions return a pmi_errno, not a HYD_status. Make sure to capture the value in the right variable type and perform the necessary check on it.
raffenet
force-pushed
the
nvhpc-warnings
branch
from
ef0474f to
26b2796
Compare
Make sure to use unsigned long long when constructing tag bits to avoid signed integer conversion warning.
Avoid directly using object free macros and causing a set but unused warning on the in_use parameter.
Use an appropriate type or cast when setting variable to -1 to avoid a sign conversion warning.
progress_state is not used when just poking the progress engine. In fact, the progress start/end macros in ch3 are no-ops. In this case the whole function can be reduced down to just MPID_Progress_poke(), so do that.
These checks are not needed and lead to warnings due to set but unused variable.
raffenet
force-pushed
the
nvhpc-warnings
branch
from
0da1020 to
2a39ad6
Compare
|
test:mpich/ch4/most |
|
test:mpich/custom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Attempt to make compilation with NVHPC compilers warning clean. I'm not 100% confident in 486c2c3 or ef0474f, but hopefully testing will prove them correct.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.