Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build, due to Rubocop error #156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix build, due to Rubocop error #156

wants to merge 1 commit into from

Conversation

64kramsystem
Copy link
Contributor

Fixes the error:

Offenses:

test/roundtrip/test_rubyc.rb:33:31: C: [Correctable] Style/HashConversion: Prefer literal hash to Hash[key: value, ...].
                parsed_line = Hash[timestamp: Time.now, line: raw_line.to_s]
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
test/roundtrip/test_rubyc.rb:40:31: C: [Correctable] Style/HashConversion: Prefer literal hash to Hash[key: value, ...].
                parsed_line = Hash[timestamp: Time.now, line: raw_line.to_s]
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

11 files inspected, 2 offenses detected, 2 offenses auto-correctable
Error: Process completed with exit code 1.

which breaks the build.

Fixes #155.

@64kramsystem
Fix build, due to Rubocop error
88219b1 
Fixes the error:

```
Offenses:

test/roundtrip/test_rubyc.rb:33:31: C: [Correctable] Style/HashConversion: Prefer literal hash to Hash[key: value, ...].
                parsed_line = Hash[timestamp: Time.now, line: raw_line.to_s]
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
test/roundtrip/test_rubyc.rb:40:31: C: [Correctable] Style/HashConversion: Prefer literal hash to Hash[key: value, ...].
                parsed_line = Hash[timestamp: Time.now, line: raw_line.to_s]
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

11 files inspected, 2 offenses detected, 2 offenses auto-correctable
Error: Process completed with exit code 1.
```

which breaks the build.
@64kramsystem
Copy link
Contributor Author

Rebased - my fork master branch was old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The build is broken, due to Rubocop error
1 participant
@64kramsystem