Public API tweaks #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am still not sure about the API of these and I consider them non-essential to a graph library. I want to focus on the essential parts, make their API good and write good documentation. On the other hand, I don't want to delete the code to be able to build upon it eventually.
This should avoid surprising behavior as, for instance, the semantics in petgraph depends on the directionality of the graph and for directed graphs `neighbors` method returns only outgoing neighbors.
pnevyk
force-pushed
the
public-api-tweaks
branch
2 times, most recently
from
dc81e26
to
5d20792
Compare
Without extend_with_edges auto-creating the vertices, this function does not make sense. Instead, the expected approach is to create a graph using from_vertices and then add edges using extend_with_edges.
pnevyk
force-pushed
the
public-api-tweaks
branch
from
51077dd
to
efc7c85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.