Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update April/May/June/July Office add-in community call #1887

Merged
merged 29 commits into from
Aug 6, 2024

Conversation

MingjiaLiu1995
Copy link
Contributor

Category

  • Content fix
  • New article

Contents of the Pull Request

Update April/May/June/July Office add-in community call blog

@MingjiaLiu1995 MingjiaLiu1995 marked this pull request as draft July 30, 2024 10:01
@MingjiaLiu1995 MingjiaLiu1995 marked this pull request as ready for review July 30, 2024 10:02
@MingjiaLiu1995
Copy link
Contributor Author

@lindalu-MSFT @davidchesnut Hi Linda and David, would you please help me review the blogs of recent community calls? For some reasons I can not add you as reviewers in this pr. Please let me know if there is anything. Thanks!

Copy link
Collaborator

@lindalu-MSFT lindalu-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix some of these things:

  • Remove /en-us/ in links
  • Clean up link text (extra unnecessary text makes is annoying to screen reader users)
  • a few voice and style gotchas
  • other minor edits

content/office-add-ins-community-call/2024-04-10/index.md Outdated Show resolved Hide resolved
content/office-add-ins-community-call/2024-04-10/index.md Outdated Show resolved Hide resolved
content/office-add-ins-community-call/2024-04-10/index.md Outdated Show resolved Hide resolved
content/office-add-ins-community-call/2024-04-10/index.md Outdated Show resolved Hide resolved
content/office-add-ins-community-call/2024-04-10/index.md Outdated Show resolved Hide resolved
content/office-add-ins-community-call/2024-07-10/index.md Outdated Show resolved Hide resolved
content/office-add-ins-community-call/2024-07-10/index.md Outdated Show resolved Hide resolved
content/office-add-ins-community-call/2024-07-10/index.md Outdated Show resolved Hide resolved
content/office-add-ins-community-call/2024-04-10/index.md Outdated Show resolved Hide resolved
content/office-add-ins-community-call/2024-04-10/index.md Outdated Show resolved Hide resolved
MingjiaLiu1995 and others added 22 commits August 1, 2024 16:38
@MingjiaLiu1995
Copy link
Contributor Author

@lindalu-MSFT Thanks Linda! Have committed all the suggestions.

@MingjiaLiu1995
Copy link
Contributor Author

@lindalu-MSFT Hi Linda, do you know who is the maintainer of this repo? The pr is blocked because the link checker fails. I checked the errors and it seems that they all come from the whole branch but not this pr. Any suggestions on who I should talk with to get this approved? Thanks!

@lindalu-MSFT
Copy link
Collaborator

@lindalu-MSFT Hi Linda, do you know who is the maintainer of this repo? The pr is blocked because the link checker fails. I checked the errors and it seems that they all come from the whole branch but not this pr. Any suggestions on who I should talk with to get this approved? Thanks!

You can check with @davidchesnut who can likely help.

@davidchesnut
Copy link
Collaborator

I believe @LuiseFreese can help with merging this PR.

@LuiseFreese LuiseFreese merged commit dd9fb66 into pnp:main Aug 6, 2024
2 of 3 checks passed
@LuiseFreese
Copy link
Collaborator

I merged this, let's see if the site builds currently. If not, I will need to ask you to fix the files as they might contain invalid markdown. Example: don't provide a heading 1 with 1 # as that's already the title which is defined in the front matter.

@LuiseFreese
Copy link
Collaborator

@MingjiaLiu1995 did you mean to submit all posts with draft true? This means they won't appear on the site.

@MingjiaLiu1995
Copy link
Contributor Author

Thanks everyone for the help. And thanks for reminding me @LuiseFreese . I have submitted a new pr to change to draft status, please help me merge it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants