Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds customer quotes docs page #6450

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Adam-it
Copy link
Contributor

@Adam-it Adam-it commented Oct 25, 2024

🎯 Aim

Based on our internal discussion the aim is to create a place where we may share feed we got from our users and customers

📸 Result

image

image

@Adam-it Adam-it added the docs label Oct 25, 2024
Copy link
Contributor

@Jwaegebaert Jwaegebaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we downscale or reposition the images? They look pretty large in the screenshot and take up a lot of space.

@Adam-it
Copy link
Contributor Author

Adam-it commented Oct 28, 2024

Can we downscale or reposition the images? They look pretty large in the screenshot and take up a lot of space.

@Jwaegebaert I updated the view and images in the PR desc so that you may have a quick glance how it looks now. When in mobile/small view the pick goes above the text, takes up the full row and is centered. Let me know if it is good enough now


<div className='row testimonial'>
<div className='col testimonial-image'>
<img src={require('!!url-loader!../images/testimonials-companies-logo/wm-reply.png').default} alt='Voitanos' />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we use this url-loader instead of the out-of-the-box file referencing using @site?
https://docusaurus.io/docs/static-assets#in-jsx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is how I found on web and worked 😜 So there isn't any specific reason except the fact I thought I should be done this way 🙂 .
Will refactor. thanks for the comment 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milanholemans I tired to refactor it but with no luck. I tried different approaches with import or using it in the src attr but also did not work 🤔. Could you guide me over this?

@andrewconnell
Copy link
Contributor

Any objections to me editing the part that's attributed to me?

  • new logo
  • it's written in the first person, but it appears to be from a company... I'd like to make it from "Andrew Connell (Voitanos)"
  • I can submit a PR against the PR's branch in @Adam-it's repo... if you're open to that

@Adam-it
Copy link
Contributor Author

Adam-it commented Nov 8, 2024

Any objections to me editing the part that's attributed to me?

  • new logo
  • it's written in the first person, but it appears to be from a company... I'd like to make it from "Andrew Connell (Voitanos)"
  • I can submit a PR against the PR's branch in @Adam-it's repo... if you're open to that

No problem. Let me know when it's ready an I will merge it ASAP

@andrewconnell
Copy link
Contributor

@Adam-it said:

Any objections to me editing the part that's attributed to me?

  • new logo
  • it's written in the first person, but it appears to be from a company... I'd like to make it from "Andrew Connell (Voitanos)"
  • I can submit a PR against the PR's branch in @Adam-it's repo... if you're open to that

No problem. Let me know when it's ready an I will merge it ASAP

Done... submitted PR => your forked branch where this PR originated from: Adam-it#2

@Adam-it
Copy link
Contributor Author

Adam-it commented Nov 17, 2024

@andrewconnell awesome
You Rock 🤩. I will merge it today and will try to convince the team to prioritize this PR so we will try to go live ASAP 👍

- switch to quote being from AC
- replace image
- edit other quote `alt` tag to be from correct source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants