-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds customer quotes docs page #6450
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we downscale or reposition the images? They look pretty large in the screenshot and take up a lot of space.
@Jwaegebaert I updated the view and images in the PR desc so that you may have a quick glance how it looks now. When in mobile/small view the pick goes above the text, takes up the full row and is centered. Let me know if it is good enough now |
|
||
<div className='row testimonial'> | ||
<div className='col testimonial-image'> | ||
<img src={require('!!url-loader!../images/testimonials-companies-logo/wm-reply.png').default} alt='Voitanos' /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why we use this url-loader instead of the out-of-the-box file referencing using @site
?
https://docusaurus.io/docs/static-assets#in-jsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is how I found on web and worked 😜 So there isn't any specific reason except the fact I thought I should be done this way 🙂 .
Will refactor. thanks for the comment 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@milanholemans I tired to refactor it but with no luck. I tried different approaches with import or using it in the src
attr but also did not work 🤔. Could you guide me over this?
Any objections to me editing the part that's attributed to me?
|
No problem. Let me know when it's ready an I will merge it ASAP |
@Adam-it said:
Done... submitted PR => your forked branch where this PR originated from: Adam-it#2 |
@andrewconnell awesome |
- switch to quote being from AC - replace image - edit other quote `alt` tag to be from correct source
🎯 Aim
Based on our internal discussion the aim is to create a place where we may share feed we got from our users and customers
📸 Result