Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructures v10 upgrade guidance #6457

Closed
wants to merge 2 commits into from

Conversation

milanholemans
Copy link
Contributor

Closes #6363


Let's not forget to update the release blog since this change will break some of its link anchors.

@milanholemans milanholemans added docs pr-priority Process this PR asap labels Nov 1, 2024
@Adam-it Adam-it self-assigned this Nov 4, 2024
Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Adam-it
Copy link
Contributor

Adam-it commented Nov 4, 2024

Ready to merge 🚀
On hold till I update the release blog post

@Adam-it
Copy link
Contributor

Adam-it commented Nov 4, 2024

@milanholemans
Copy link
Contributor Author

All of the links you mentioned were changed, no?

@Adam-it
Copy link
Contributor

Adam-it commented Nov 5, 2024

All of the links you mentioned were changed, no?

Hmmm, yes I think your right 🤦‍♂️ I must have checked it on wrong branch locally.
Thanks for the double confirmation I will recheck and update the blog post

@Adam-it
Copy link
Contributor

Adam-it commented Nov 5, 2024

@milanholemans I prepared the PR with required changes in the release blog post pnp/blog#1966
You may give it a check if needed.
When merging this PR I will merge the update to the release blog post at same time

@Adam-it
Copy link
Contributor

Adam-it commented Nov 5, 2024

Merged manually. Awesome work 👏. You Rock 🤩

@Adam-it Adam-it closed this Nov 5, 2024
@milanholemans milanholemans deleted the restructure-v10 branch November 5, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure v10 upgrade guidance page
2 participants