Skip to content

See cell assignments of fibonacci circuit #7

See cell assignments of fibonacci circuit

See cell assignments of fibonacci circuit #7

GitHub Actions / Clippy (beta) failed Oct 21, 2024 in 1s

Clippy (beta)

6 errors, 129 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 6
Warning 129
Note 0
Help 0

Versions

  • rustc 1.83.0-beta.2 (88c1c3c11 2024-10-18)
  • cargo 1.83.0-beta.2 (15fbd2f60 2024-10-08)
  • clippy 0.1.83 (88c1c3c 2024-10-18)

Annotations

Check warning on line 127 in halo2_gadgets/src/utilities.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/utilities.rs:127:34
    |
127 |             _phantom: PhantomData::default(),
    |                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 118 in halo2_gadgets/src/utilities.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/utilities.rs:118:34
    |
118 |             _phantom: PhantomData::default(),
    |                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 103 in halo2_gadgets/src/utilities.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/utilities.rs:103:34
    |
103 |             _phantom: PhantomData::default(),
    |                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 52 in halo2_gadgets/src/utilities/lookup_range_check.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
  --> halo2_gadgets/src/utilities/lookup_range_check.rs:52:38
   |
52 |                 _phantom: PhantomData::default(),
   |                                      ^^^^^^^^^^^ help: remove this call to `default`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 1066 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of `Iterator::fold` on a type that implements `Try`

warning: usage of `Iterator::fold` on a type that implements `Try`
    --> halo2_proofs/src/dev.rs:1066:30
     |
1066 | ...                   .fold(Ok(()), |acc, res| acc.and(res))
     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold((), |acc, res| ...)`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
     = note: `-W clippy::manual-try-fold` implied by `-W clippy::all`
     = help: to override `-W clippy::all` add `#[allow(clippy::manual_try_fold)]`

Check warning on line 688 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> halo2_proofs/src/dev.rs:683:41
    |
683 | / ...                   &util::load_instance(
684 | | ...                       n,
685 | | ...                       row,
686 | | ...                       &self.cs.instance_queries,
687 | | ...                       &self.instance,
688 | | ...                   ),
    | |_______________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
    |
683 ~                                         util::load_instance(
684 +                                             n,
685 +                                             row,
686 +                                             &self.cs.instance_queries,
687 +                                             &self.instance,
688 ~                                         ),
    |

Check warning on line 682 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> halo2_proofs/src/dev.rs:682:41
    |
682 | ...                   &util::load(n, row, &self.cs.advice_queries, &self.advice),
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.advice_queries, &self.advice)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 681 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> halo2_proofs/src/dev.rs:681:41
    |
681 | ...                   &util::load(n, row, &self.cs.fixed_queries, &self.fixed),
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.fixed_queries, &self.fixed)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 352 in halo2_proofs/src/dev/tfp.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the following explicit lifetimes could be elided: 'cs

warning: the following explicit lifetimes could be elided: 'cs
   --> halo2_proofs/src/dev/tfp.rs:352:6
    |
352 | impl<'cs, F: Field, CS: Assignment<F>> Assignment<F> for TracingAssignment<'cs, F, CS> {
    |      ^^^                                                                   ^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
352 - impl<'cs, F: Field, CS: Assignment<F>> Assignment<F> for TracingAssignment<'cs, F, CS> {
352 + impl<F: Field, CS: Assignment<F>> Assignment<F> for TracingAssignment<'_, F, CS> {
    |

Check warning on line 225 in halo2_proofs/src/dev/tfp.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the following explicit lifetimes could be elided: 'r

warning: the following explicit lifetimes could be elided: 'r
   --> halo2_proofs/src/dev/tfp.rs:225:6
    |
225 | impl<'r, F: Field> RegionLayouter<F> for TracingRegion<'r, F> {
    |      ^^                                                ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
225 - impl<'r, F: Field> RegionLayouter<F> for TracingRegion<'r, F> {
225 + impl<F: Field> RegionLayouter<F> for TracingRegion<'_, F> {
    |

Check warning on line 121 in halo2_proofs/src/dev/tfp.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the following explicit lifetimes could be elided: 'c

warning: the following explicit lifetimes could be elided: 'c
   --> halo2_proofs/src/dev/tfp.rs:121:6
    |
121 | impl<'c, F: Field, C: Circuit<F>> Circuit<F> for TracingCircuit<'c, F, C> {
    |      ^^                                                         ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
121 - impl<'c, F: Field, C: Circuit<F>> Circuit<F> for TracingCircuit<'c, F, C> {
121 + impl<F: Field, C: Circuit<F>> Circuit<F> for TracingCircuit<'_, F, C> {
    |

Check warning on line 414 in halo2_proofs/src/dev/cost.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
   --> halo2_proofs/src/dev/cost.rs:414:33
    |
414 |             _marker: PhantomData::default(),
    |                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 371 in halo2_proofs/src/dev/cost.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
   --> halo2_proofs/src/dev/cost.rs:371:33
    |
371 |             _marker: PhantomData::default(),
    |                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 328 in halo2_proofs/src/dev/cost.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
   --> halo2_proofs/src/dev/cost.rs:328:33
    |
328 |             _marker: PhantomData::default(),
    |                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 174 in halo2_proofs/src/poly.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/poly.rs:174:22
    |
174 |                 .zip(inv_denoms.into_iter())
    |                      ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_denoms`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/88c1c3c1102bbf3860891bfa52b7ddd9f26aec2f/library/core/src/iter/traits/iterator.rs:598:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 167 in halo2_proofs/src/poly.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this bound is already specified as the supertrait of `ExactSizeIterator`

warning: this bound is already specified as the supertrait of `ExactSizeIterator`
   --> halo2_proofs/src/poly.rs:167:26
    |
167 |         inv_denoms: impl Iterator<Item = F> + ExactSizeIterator,
    |                          ^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
    = note: `-W clippy::implied-bounds-in-impls` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::implied_bounds_in_impls)]`
help: try removing this bound
    |
167 -         inv_denoms: impl Iterator<Item = F> + ExactSizeIterator,
167 +         inv_denoms: impl ExactSizeIterator<Item = F>,
    |

Check warning on line 159 in halo2_proofs/src/poly.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/poly.rs:159:14
    |
159 |         .zip(assigned_denominators.into_iter())
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `assigned_denominators`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/88c1c3c1102bbf3860891bfa52b7ddd9f26aec2f/library/core/src/iter/traits/iterator.rs:598:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 125 in halo2_proofs/src/poly/multiopen/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> halo2_proofs/src/poly/multiopen/prover.rs:125:6
    |
125 | impl<'a, C: CurveAffine> PartialEq for PolynomialPointer<'a, C> {
    |      ^^                                                  ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
125 - impl<'a, C: CurveAffine> PartialEq for PolynomialPointer<'a, C> {
125 + impl<C: CurveAffine> PartialEq for PolynomialPointer<'_, C> {
    |

Check warning on line 105 in halo2_proofs/src/poly/multiopen/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/poly/multiopen/prover.rs:105:58
    |
105 |     let (p_poly, p_poly_blind) = q_polys.into_iter().zip(q_blinds.into_iter()).fold(
    |                                                          ^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `q_blinds`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/88c1c3c1102bbf3860891bfa52b7ddd9f26aec2f/library/core/src/iter/traits/iterator.rs:598:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 124 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
   --> halo2_proofs/src/poly/evaluator.rs:124:36
    |
124 |             _evaluator: PhantomData::default(),
    |                                    ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 78 in halo2_proofs/src/poly/evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
  --> halo2_proofs/src/poly/evaluator.rs:78:36
   |
78 |             _evaluator: PhantomData::default(),
   |                                    ^^^^^^^^^^^ help: remove this call to `default`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
   = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all`
   = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`

Check warning on line 559 in halo2_proofs/src/poly/domain.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> halo2_proofs/src/poly/domain.rs:559:20
    |
559 |     let xn = x.pow(&[8, 0, 0, 0]);
    |                    ^^^^^^^^^^^^^ help: change this to: `[8, 0, 0, 0]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 549 in halo2_proofs/src/poly/domain.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> halo2_proofs/src/poly/domain.rs:549:38
    |
549 |         points.push(domain.omega.pow(&[i, 0, 0, 0]));
    |                                      ^^^^^^^^^^^^^ help: change this to: `[i, 0, 0, 0]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 322 in halo2_proofs/src/plonk/verifier.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/plonk/verifier.rs:319:25
    |
319 | /                         lookups
320 | |                             .iter()
321 | |                             .flat_map(move |p| p.queries(vk, x))
322 | |                             .into_iter(),
    | |________________________________________^
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/88c1c3c1102bbf3860891bfa52b7ddd9f26aec2f/library/core/src/iter/traits/iterator.rs:479:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
help: consider removing the `.into_iter()`
    |
319 ~                         lookups
320 +                             .iter()
321 ~                             .flat_map(move |p| p.queries(vk, x)),
    |

Check warning on line 276 in halo2_proofs/src/plonk/verifier.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/plonk/verifier.rs:259:25
    |
259 | /                         lookups
260 | |                             .iter()
261 | |                             .zip(vk.cs.lookups.iter())
262 | |                             .flat_map(move |(p, argument)| {
...   |
275 | |                             })
276 | |                             .into_iter(),
    | |________________________________________^
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/88c1c3c1102bbf3860891bfa52b7ddd9f26aec2f/library/core/src/iter/traits/iterator.rs:479:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
help: consider removing the `.into_iter()`
    |
259 ~                         lookups
260 +                             .iter()
261 +                             .zip(vk.cs.lookups.iter())
262 +                             .flat_map(move |(p, argument)| {
263 +                                 p.expressions(
264 +                                     l_0,
265 +                                     l_last,
266 +                                     l_blind,
267 +                                     argument,
268 +                                     theta,
269 +                                     beta,
270 +                                     gamma,
271 +                                     advice_evals,
272 +                                     fixed_evals,
273 +                                     instance_evals,
274 +                                 )
275 ~                             }),
    |