Feature/PODAAC-5877: Upgrade to Java 11 and CMA 2.0.3 #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorper
changed the title
skorper
reviewed
Oct 13, 2023
CHANGELOG.md
Outdated
| @@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ## [Unreleased] | |||
| ### Added | |||
| ### Changed | |||
| - **PODAAC-xxxx** | |||
There was a problem hiding this comment.
Can you update the ticket #?
skorper
reviewed
Oct 13, 2023
CHANGELOG.md
Outdated
| @@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ## [Unreleased] | |||
| ### Added | |||
| ### Changed | |||
| - **PODAAC-xxxx** | |||
| - Support java 17 | |||
There was a problem hiding this comment.
Can you update this to Java 11?
skorper
reviewed
Oct 13, 2023
README.md
Outdated
| -Dsonar.host.url=http://localhost:9000 \ | ||
| -Dsonar.token=sqp_6dc05b1aa1f622b45112927d2a0510f209776860 | ||
|
|
||
| * Makde sure using java 17 and gradle 8.3 |
There was a problem hiding this comment.
Suggested change
| * Makde sure using java 17 and gradle 8.3 | |
| * Make sure using java 11 and gradle 8.3 |
|
@skorper I have addressed all comments and the build is a success. |
skorper
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support PODAAC-5877, upgrade to CMA 2.0.3
Ticket: [PODAAC-5877]
Description
make CNM2CMA cumulus 16 and CMA 2.0.3 compatible.
Overview of work done
Upgrade to make use of CMA 2.0.3
Java 11
dependency cumulus-message-adapter 1.3.9 -> 2.0.0
Overview of verification done
Download the github action build artifact, un-zip and use
javap -verbose XXXX.class
to verify the compiled class file is at version 55, which is java11.
Integration testing with MetadataAggregator and CNMResponse
Tested in SIT:
Explain how you tested in SIT, if applicable
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request