feat: add context parsers for hybrid headers #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass on `x-podium-app-id` as `appId` on the context - Pass on `x-podium-base-font-size` as `baseFontSize` on the context - Override `deviceType` with `x-podium-device-type`
wkillerud
commented
Jul 23, 2024
| }), | ||
| ); | ||
| const result = parser.parse(incoming); | ||
| t.equal(result, 'hybrid-ios'); |
There was a problem hiding this comment.
This test gave me pause. Should we maybe separate the signal for "I'm in a hybrid web view" from the device type?
There was a problem hiding this comment.
@trygve-lie I think I remember we discussed the device-type header and agreed that this was fine (setting it to hybrid-ios and hybrid-android)?
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
# [5.1.0](v5.0.29...v5.1.0) (2024-09-30) ### Features * add context parsers for hybrid headers ([#260](#260)) ([73a7581](73a7581))
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-podium-app-idasappIdon the contextx-podium-base-font-sizeasbaseFontSizeon the contextdeviceTypewithx-podium-device-type