fix: run podium processes earlier in Fastify lifecycle #258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When an error occurs in the Fastify lifecycle, subsequent hooks won't be run and so if an error occurs quite early, the preHandler is not run. This means that pretty much any time an error occurs and the error handler kicks in, reply.app.podium will be an empty object and Podium won't have had a chance to run parsers etc. I suspect this is not what we want and that we would be better off running Podium stuff as early as possible. This PR does this by moving Podium setup into an earlier onRequest hook.
Thoughts @trygve-lie ?